hunhoffe commented on code in PR #5278:
URL: https://github.com/apache/openwhisk/pull/5278#discussion_r926919483
##########
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/Scheduler.scala:
##########
@@ -289,6 +292,11 @@ object Scheduler {
implicit val logger = new
AkkaLogging(akka.event.Logging.getLogger(actorSystem, this))
+ if (useClusterBootstrap) {
+ AkkaManagement(actorSystem).start()
+ ClusterBootstrap(actorSystem).start()
+ }
Review Comment:
@ningyougang, I believe the ```ShardingContainerPoolBalancer``` only calls
```Cluster(actorSystem)``` because it needs access to the cluster object in
order to manage cluster state, as part of the main functionality of that class.
Since the Scheduler and Controller are not performing cluster management tasks,
I do not think they need to make this call (and thus do not need the check for
seed nodes).
If we wanted to do a check just to make sure configuration is correct, I
could add that (e.g.,
```scala
...
} else {
/* create error if seed nodes not set */
loadConfigOrThrow[Seq[String]]("akka.cluster.seed-nodes")
}
```
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
