ningyougang commented on code in PR #5290:
URL: https://github.com/apache/openwhisk/pull/5290#discussion_r926350523
##########
tests/src/test/scala/actionContainers/ActionContainer.scala:
##########
@@ -52,6 +52,7 @@ import org.apache.openwhisk.core.containerpool.Container
trait ActionContainer {
def init(value: JsValue): (Int, Option[JsObject])
def run(value: JsValue): (Int, Option[JsObject])
+ def runForJsArray(value: JsValue): (Int, Option[JsArray])
Review Comment:
Normally, need to change `def run(...)` as below
```
def run(value: JsValue): (Int, Option[JsValue]) // Option[JsObject] ->
Option[JsValue]
```
But i just add another new method here, two reasons.
* If change `def run` directly, there has a lot of changes.
* It is just for test, so i just add another new method, there has no need
to introduce too many code modifications
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
