[GitHub] [openwhisk] ningyougang commented on a diff in pull request #5290: Support array result for common action and sequence action

Tue, 26 Jul 2022 01:35:04 -0700 


ningyougang commented on code in PR #5290:
URL: https://github.com/apache/openwhisk/pull/5290#discussion_r929682591


##########
common/scala/src/main/scala/org/apache/openwhisk/core/entity/ActivationResult.scala:
##########
@@ -203,7 +203,7 @@ protected[core] object ActivationResponse extends 
DefaultJsonProtocol {
         truncated match {
           case None =>
             val sizeOpt = Option(str).map(_.length)
-            Try { str.parseJson.asJsObject } match {
+            Try { str.parseJson } match {
               case scala.util.Success(result @ JsObject(fields)) =>

Review Comment:
   * If without this pr, i think we can remove `.asJsObject`.
   * But with this pr, we need to support JsArray, must remove `.asJsObject` to 
match below codes
   
![image](https://user-images.githubusercontent.com/11749867/180961843-6584f818-91bc-4c53-9ac8-ef8d26e73530.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to