style95 commented on code in PR #5278:
URL: https://github.com/apache/openwhisk/pull/5278#discussion_r933764471
##########
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Controller.scala:
##########
@@ -230,6 +233,10 @@ object Controller {
def main(args: Array[String]): Unit = {
implicit val actorSystem = ActorSystem("controller-actor-system")
implicit val logger = new
AkkaLogging(akka.event.Logging.getLogger(actorSystem, this))
+ if (useClusterBootstrap) {
Review Comment:
AFAIK, `FPCPoolBalancer` does not need to discover different actors in a
remote node.
The scheduler does. `ShardingPoolBalancer` needs a cluster to determine the
number of controller nodes.
This is for sharding and `ShardingPoolBalancer` already has the same logic.
That's why I asked if akka-cluster bootstrap is required for all load
balancers other than `ShardingPoolBalancer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
