hunhoffe commented on code in PR #5278:
URL: https://github.com/apache/openwhisk/pull/5278#discussion_r929015057
##########
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Controller.scala:
##########
@@ -230,6 +233,10 @@ object Controller {
def main(args: Array[String]): Unit = {
implicit val actorSystem = ActorSystem("controller-actor-system")
implicit val logger = new
AkkaLogging(akka.event.Logging.getLogger(actorSystem, this))
+ if (useClusterBootstrap) {
+ AkkaManagement(actorSystem).start()
+ ClusterBootstrap(actorSystem).start()
+ }
Review Comment:
I believe it would be correct to delete lines 158 & 159 (which I will do),
but the ShardingContainerPoolBalancer still needs a handle to the cluster
object (when a cluster is created) so I believe the rest needs to stay.
Unless we make it so the controller fails if a cluster is not started (e.g.,
no cluster discovery and no seed nodes), then we could replace the above
portion with something like:
```scala
private val cluster: Cluster = Cluster(actorSystem)
```
However, I'm not sure how well that jives with the standalone version of
OpenWhisk. I'd have to look into that. I was trying to keep my changes minimal,
so I did not go in that direction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
