style95 commented on code in PR #5338:
URL: https://github.com/apache/openwhisk/pull/5338#discussion_r1000209457
##########
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Controller.scala:
##########
@@ -167,6 +167,22 @@ class Controller(val instance: ControllerInstanceId,
}
}
+ /**
+ * Handles GET /activation URI.
+ *
+ * @return running activation
+ */
+ protected[controller] val activationStatus = {
+ implicit val executionContext = actorSystem.dispatcher
+ (path("activation") & get) {
Review Comment:
This is based on my experience that using simple and more memorable URLs and
not using case-sensitive words for APIs is better in many cases.
##########
core/controller/src/main/scala/org/apache/openwhisk/core/controller/Controller.scala:
##########
@@ -167,6 +167,22 @@ class Controller(val instance: ControllerInstanceId,
}
}
+ /**
+ * Handles GET /activation URI.
+ *
+ * @return running activation
+ */
+ protected[controller] val activationStatus = {
Review Comment:
Yes, that is handled by
https://github.com/apache/openwhisk/pull/5338/files#diff-379956107a78f18274d3895bbbb268b964cc5f89ac3601333c4255cc0bb7632dR380
It will use the number of in-flight activations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
