style95 commented on code in PR #5338: URL: https://github.com/apache/openwhisk/pull/5338#discussion_r1008659400
########## core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/queue/MemoryQueue.scala: ########## @@ -154,8 +168,8 @@ class MemoryQueue(private val etcdClient: EtcdClient, private val staleQueueRemovedMsg = QueueRemoved(invocationNamespace, action.toDocId.asDocInfo(revision), None) private val actionRetentionTimeout = MemoryQueue.getRetentionTimeout(actionMetaData, queueConfig) - private[queue] var containers = Set.empty[String] - private[queue] var creationIds = Set.empty[String] + private[queue] var containers = java.util.concurrent.ConcurrentHashMap.newKeySet[String]().asScala Review Comment: This was one of the reasons for failed activations during the deployment. The `Set` was not thread-safe. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
