bdoyle0182 commented on code in PR #5348:
URL: https://github.com/apache/openwhisk/pull/5348#discussion_r1012215339
##########
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala:
##########
@@ -518,6 +505,8 @@ class FunctionPullingContainerProxy(
data.action.fullyQualifiedName(withVersion = true),
data.action.rev,
Some(data.clientProxy))
+
+ case x: Event if x.event != PingCache => delay
Review Comment:
My concern with having a stash message for all events and then unstash it on
state transition, is that it was the root cause of the edge case with the
orphaned etcd data for pausing / unpausing containers where a generic
`FailureMessage` would be stashed and then when it transitioned to Running it
would unstash the `FailureMessage` leading to the bug / unexpected behavior.
I just want to make sure that we're 100% sure a catch all here will not have
any unknown side effects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
