style95 commented on code in PR #5348:
URL: https://github.com/apache/openwhisk/pull/5348#discussion_r1012518939
##########
core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/ActivationClientProxy.scala:
##########
@@ -164,9 +166,12 @@ class ActivationClientProxy(
stay()
case _: ActionMismatch =>
- logging.error(this, s"[${containerId.asString}] action version does
not match: $action")
+ val errorMsg = s"[${containerId.asString}] action version does not
match: $action"
+ logging.error(this, errorMsg)
c.activationClient.close().andThen {
- case _ => self ! ClientClosed
+ case _ =>
Review Comment:
I think so.
As I stated
[here](https://github.com/apache/openwhisk/pull/5348/files/997f8a93eaadf32815e42c93252b70dfdaddd834#r1011720630),
when the ActivationClientProxy initiates the clean-up process, it didn't let
the ContainerProxy know. The ETCD data clean-up is handled by ContainerProxy,
accordingly, the data was not removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
