bdoyle0182 commented on code in PR #5386:
URL: https://github.com/apache/openwhisk/pull/5386#discussion_r1127206947
##########
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/queue/MemoryQueue.scala:
##########
@@ -574,7 +576,7 @@ class MemoryQueue(private val etcdClient: EtcdClient,
case Event(DropOld, _) =>
if (queue.nonEmpty && Duration
.between(queue.head.timestamp, clock.now())
- .compareTo(Duration.ofMillis(actionRetentionTimeout)) < 0) {
+ .compareTo(Duration.ofMillis(actionRetentionTimeout)) >= 0) {
Review Comment:
Based off of the same comparison in the `checkToDropStaleActivation`
function, I think this is actually a bug such that the error log below this
will never get emitted in order to debug the container state of the queue when
the not processing case occurs. Could use sanity check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
