bdoyle0182 commented on code in PR #5386:
URL: https://github.com/apache/openwhisk/pull/5386#discussion_r1127322378
##########
core/scheduler/src/main/scala/org/apache/openwhisk/core/scheduler/queue/MemoryQueue.scala:
##########
@@ -1201,6 +1207,13 @@ object MemoryQueue {
logging.info(
this,
s"[$invocationNamespace:$action:$stateName] some activations are stale
msg: ${queue.head.msg.activationId}.")
+ val currentTime = Instant.now.toEpochMilli
+ if (currentTime - lastActivationExecutedTime.get() > maxRetentionMs) {
+ MetricEmitter.emitGaugeMetric(
+ LoggingMarkers
+ .SCHEDULER_QUEUE_NOT_PROCESSING(invocationNamespace,
action.asString, action.toStringWithoutVersion),
Review Comment:
Right I noted that in the description
`The system configured queue retention timeout is not longer than the max
timeout of an action such that all available containers are in use up to the
limit and are validly in use longer than the max retention timeout of the queue
and the system operator should take action anyways to correct that.`
I could also look into making it such that the queue retention time is
dynamic to the action timeout of the function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
