quintenp01 commented on code in PR #5551:
URL: https://github.com/apache/openwhisk/pull/5551#discussion_r2441397206
##########
core/scheduler/src/main/java/Empty.java:
##########
Review Comment:
did you mean to remove this?
##########
common/scala/src/main/scala/org/apache/openwhisk/connector/kafka/KamonMetricsReporter.scala:
##########
@@ -122,8 +122,11 @@ object KamonMetricsReporter {
}
def isCounterMetric(metric: KafkaMetric): Boolean = Try(metric.measurable())
match {
- case Success(_: Total) => true
- case _ => false
+ case Success(_: CumulativeCount) => true
+ case Success(m) if m.getClass.getSimpleName == "Total" => true
+ case Success(m) if m.getClass.getSimpleName == "WindowedSum" &&
metric.metricName().name().endsWith("-total") =>
+ true
+ case _ => false
Review Comment:
it looks like `Total` was replaced with `CumulativeSum`, would capturing
that in the case suffice here?
##########
common/scala/src/main/resources/s3-reference.conf:
##########
@@ -110,6 +110,29 @@ whisk {
# Which version of the list bucket api to use. Set to 1 to use the old
style version 1 API.
# By default the newer version 2 api is used.
list-bucket-api-version = 2
+
+ # Validate the object key before making requests to S3
+ validate-object-key = true
+
+ # Whether to sign anonymous requests
+ sign-anonymous-requests = true
+
+ # Default settings corresponding to automatic retry of requests in an S3
stream.
+ retry-settings {
+ # The maximum number of additional attempts (following transient
errors) that will be made to process a given request before giving up.
+ max-retries = 3
+ # The minimum delay between request retries.
+ min-backoff = 200ms
+ # The maximum delay between request retries.
+ max-backoff = 10s
+ # Random jitter factor applied to retry delay calculation.
+ random-factor = 0.0
+ }
+
+ # Various settings for the multipart upload
+ multipart-upload {
+ retry-settings = ${whisk.s3.pekko-connectors.retry-settings}
+ }
Review Comment:
Are these settings new or were they the alpakka defaults?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
