style95 commented on code in PR #5551: URL: https://github.com/apache/openwhisk/pull/5551#discussion_r2441496430
########## core/controller/src/main/resources/application.conf: ########## @@ -17,15 +17,19 @@ # common logging configuration see common scala include "logging" -include "akka-http-version" +include "pekko-http-version" -# http://doc.akka.io/docs/akka-http/current/scala/http/configuration.html +# https://pekko.apache.org/docs/pekko-http/current/configuration.html # descriptions inlined below for convenience -akka.http { +pekko.http { server { + # Bind to all interfaces in containerized environments + bind-host = "0.0.0.0" + default-http-port = 10001 Review Comment: Is this supposed to be changed by a runtime parameter for other than the first controller? ########## common/scala/src/main/resources/s3-reference.conf: ########## @@ -110,6 +110,29 @@ whisk { # Which version of the list bucket api to use. Set to 1 to use the old style version 1 API. # By default the newer version 2 api is used. list-bucket-api-version = 2 + + # Validate the object key before making requests to S3 + validate-object-key = true Review Comment: Are these related to pekko migration? ########## common/scala/build.gradle: ########## @@ -48,26 +48,29 @@ dependencies { } api "io.spray:spray-json_${gradle.scala.depVersion}:1.3.5" api "com.lihaoyi:fastparse_${gradle.scala.depVersion}:2.3.0" - api "com.typesafe.akka:akka-actor_${gradle.scala.depVersion}:${gradle.akka.version}" - api "com.typesafe.akka:akka-stream_${gradle.scala.depVersion}:${gradle.akka.version}" - api "com.typesafe.akka:akka-slf4j_${gradle.scala.depVersion}:${gradle.akka.version}" - api "com.typesafe.akka:akka-cluster_${gradle.scala.depVersion}:${gradle.akka.version}" - api "com.typesafe.akka:akka-cluster-metrics_${gradle.scala.depVersion}:${gradle.akka.version}" - api "com.typesafe.akka:akka-cluster-tools_${gradle.scala.depVersion}:${gradle.akka.version}" - api "com.typesafe.akka:akka-distributed-data_${gradle.scala.depVersion}:${gradle.akka.version}" - - api "com.typesafe.akka:akka-http-core_${gradle.scala.depVersion}:${gradle.akka_http.version}" - api "com.typesafe.akka:akka-http-spray-json_${gradle.scala.depVersion}:${gradle.akka_http.version}" - - api "com.lightbend.akka:akka-stream-alpakka-file_${gradle.scala.depVersion}:2.0.2" - - api "ch.qos.logback:logback-classic:1.2.13" - api "org.slf4j:jcl-over-slf4j:1.7.25" - api "org.slf4j:log4j-over-slf4j:1.7.25" + api "org.apache.pekko:pekko-actor_${gradle.scala.depVersion}:${gradle.pekko.version}" + api "org.apache.pekko:pekko-actor-typed_${gradle.scala.depVersion}:${gradle.pekko.version}" + api "org.apache.pekko:pekko-cluster-typed_${gradle.scala.depVersion}:${gradle.pekko.version}" + api "org.apache.pekko:pekko-stream_${gradle.scala.depVersion}:${gradle.pekko.version}" + api "org.apache.pekko:pekko-slf4j_${gradle.scala.depVersion}:${gradle.pekko.version}" + api "org.apache.pekko:pekko-cluster_${gradle.scala.depVersion}:${gradle.pekko.version}" + api "org.apache.pekko:pekko-cluster-metrics_${gradle.scala.depVersion}:${gradle.pekko.version}" + api "org.apache.pekko:pekko-cluster-tools_${gradle.scala.depVersion}:${gradle.pekko.version}" + api "org.apache.pekko:pekko-distributed-data_${gradle.scala.depVersion}:${gradle.pekko.version}" + + api "org.apache.pekko:pekko-http-core_${gradle.scala.depVersion}:${gradle.pekko_http.version}" + api "org.apache.pekko:pekko-http-spray-json_${gradle.scala.depVersion}:${gradle.pekko_http.version}" + + api "org.apache.pekko:pekko-connectors-file_${gradle.scala.depVersion}:${gradle.pekko_kafka.version}" + + api "ch.qos.logback:logback-classic:1.3.15" + api "org.slf4j:slf4j-api:2.0.9" + api "org.slf4j:jcl-over-slf4j:2.0.17" + api "org.slf4j:log4j-over-slf4j:2.0.17" api "commons-codec:commons-codec:1.9" api "commons-io:commons-io:2.14.0" api "commons-collections:commons-collections:3.2.2" - api "org.apache.kafka:kafka-clients:2.8.2" + api "org.apache.kafka:kafka-clients:3.9.1" Review Comment: Does this imply downstream will need a newer version of Kafka brokers? ########## core/scheduler/src/main/java/Empty.java: ########## @@ -1,22 +0,0 @@ -/* Review Comment: 👍 ########## core/standalone/src/main/scala/org/apache/openwhisk/standalone/KafkaLauncher.scala: ########## @@ -57,11 +56,11 @@ class KafkaLauncher( // Here controller / invoker will use LISTENER_LOCAL since they run in the same JVM as the embedded Kafka // and Kafka UI will run in a Docker container and use LISTENER_DOCKER val brokerProps = Map( - KafkaConfig.ListenersProp -> s"LISTENER_LOCAL://localhost:$kafkaPort,LISTENER_DOCKER://localhost:$kafkaDockerPort", - KafkaConfig.AdvertisedListenersProp -> s"LISTENER_LOCAL://localhost:$kafkaPort,LISTENER_DOCKER://${StandaloneDockerSupport + "listeners" -> s"LISTENER_LOCAL://localhost:$kafkaPort,LISTENER_DOCKER://localhost:$kafkaDockerPort", Review Comment: Is this also relevant to the Pekko migration? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
