sandeep-paliwal commented on a change in pull request #2282: Distributed 
tracing support #2192
URL: 
https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r120584248
 
 

 ##########
 File path: common/scala/src/main/resources/application.conf
 ##########
 @@ -12,3 +12,22 @@ akka.http {
         max-open-requests = 128
     }
 }
+
+akka.tracing {
+    #zipkin configuration
+    host = "localhost"
+    host = ${?TRACING_HOST} # Override default HOST by enviornment variable
+    port = 9410 # default
+    port = ${?TRACING_PORT} # Override default PORT by enviornment variable
+    sample-rate = 100 # by default trace every 100th request
+    sample-rate = ${?TRACING_SAMPLE_RATE} # Override default Sample_Rate by 
enviornment variable
+
+    enabled = false
+    enabled = ${?TRACING_ENABLED} # Override default Enabled by enviornment 
variable
 
 Review comment:
   @adriancole this will override the hardcoded default by environment variable 
if its set 
[(https://www.playframework.com/documentation/2.5.x/ProductionConfiguration#Using-environment-variables)](https://www.playframework.com/documentation/2.5.x/ProductionConfiguration#Using-environment-variables)
   Not sure if this is what your are referring to.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to