sandeep-paliwal commented on a change in pull request #2282: Distributed 
tracing support #2192
URL: 
https://github.com/apache/incubator-openwhisk/pull/2282#discussion_r120834082
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/common/Logging.scala
 ##########
 @@ -171,6 +226,10 @@ case class LogMarkerToken(component: String, action: 
String, state: String) {
 
     def asFinish = copy(state = LoggingMarkers.finish)
     def asError = copy(state = LoggingMarkers.error)
+
+    def getServiceName(): String = {
+        component + "_" + action
 
 Review comment:
   Here service name is name of logical unit within context of action 
execution. Ex. invoker_activationinit or invoker_dockerpause etc. So 
combination of two is span name here. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to