rabbah commented on a change in pull request #2327: Update OPTIONS Respones for
Web Actions (Review)
URL:
https://github.com/apache/incubator-openwhisk/pull/2327#discussion_r121712032
##########
File path:
core/controller/src/main/scala/whisk/core/controller/WebActions.scala
##########
@@ -406,6 +413,11 @@ trait WhiskWebActionsApi
requestMethodParamsAndPath { context =>
provide(fullyQualifiedActionName(actionName)) {
fullActionName =>
onComplete(verifyWebAction(fullActionName,
onBehalfOf.isDefined)) {
+ case Success((actionOwnerIdentity,
action)) if context.method == OPTIONS &&
Review comment:
i think i prefer to move the `if` predicate inside a single case statement
for the `Success((actionOwnerIdentity, action))`; the predicate is sufficiently
long I don't think we gain any readability or benefit from this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
