rabbah commented on a change in pull request #2327: Update OPTIONS Respones for
Web Actions (Review)
URL:
https://github.com/apache/incubator-openwhisk/pull/2327#discussion_r122080433
##########
File path:
core/controller/src/main/scala/whisk/core/controller/WebActions.scala
##########
@@ -291,10 +292,16 @@ protected[core] object WhiskWebActionsApi extends
Directives {
}
}
+protected[controller] trait RespondWithMethods extends RespondWithHeaders {
Review comment:
I find this trait confusing - you can add the parent trait to the web
actions api and override there.
I don't think we're gaining anything from this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services