mdeuser commented on a change in pull request #2326: (Review) Alphabetize
URL:
https://github.com/apache/incubator-openwhisk/pull/2326#discussion_r125667262
##########
File path: tools/cli/go-whisk-cli/commands/util.go
##########
@@ -298,47 +349,16 @@ func printSummary(collection interface{}) {
case *whisk.Activation:
}
}
-
-func printActionList(actions []whisk.Action) {
- fmt.Fprintf(color.Output, "%s\n", boldString("actions"))
- for _, action := range actions {
- publishState := wski18n.T("private")
- kind := getValueString(action.Annotations, "exec")
- fmt.Printf("%-70s %s %s\n", fmt.Sprintf("/%s/%s", action.Namespace,
action.Name), publishState, kind)
- }
-}
-
-func printTriggerList(triggers []whisk.Trigger) {
- fmt.Fprintf(color.Output, "%s\n", boldString("triggers"))
- for _, trigger := range triggers {
- publishState := wski18n.T("private")
- fmt.Printf("%-70s %s\n", fmt.Sprintf("/%s/%s", trigger.Namespace,
trigger.Name), publishState)
- }
-}
-
-func printPackageList(packages []whisk.Package) {
- fmt.Fprintf(color.Output, "%s\n", boldString("packages"))
- for _, xPackage := range packages {
- publishState := wski18n.T("private")
- if xPackage.Publish != nil && *xPackage.Publish {
- publishState = wski18n.T("shared")
- }
- fmt.Printf("%-70s %s\n", fmt.Sprintf("/%s/%s", xPackage.Namespace,
xPackage.Name), publishState)
- }
-}
-
-func printRuleList(rules []whisk.Rule) {
- fmt.Fprintf(color.Output, "%s\n", boldString("rules"))
- for _, rule := range rules {
- publishState := wski18n.T("private")
- fmt.Printf("%-70s %s\n", fmt.Sprintf("/%s/%s", rule.Namespace,
rule.Name), publishState)
- }
-}
-
-func printNamespaceList(namespaces []whisk.Namespace) {
- fmt.Fprintf(color.Output, "%s\n", boldString("namespaces"))
- for _, namespace := range namespaces {
- fmt.Printf("%s\n", namespace.Name)
+// Used to print Action, Tigger, Package, and Rule lists
+// Param: Takes in a array of Sortable interface, and the name of the command
Review comment:
Actual argument type of an array of Printables, not Sortables
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
