mdeuser commented on a change in pull request #2326: (Review) Alphabetize
URL:
https://github.com/apache/incubator-openwhisk/pull/2326#discussion_r125701790
##########
File path: tools/cli/go-whisk-cli/commands/api.go
##########
@@ -445,8 +453,11 @@ var apiListCmd = &cobra.Command{
* Takes an API object (containing one more more single
basepath/relpath/operation triplets)
* and some filtering configuration. For each API endpoint matching the
filtering criteria, display
* each endpoint's configuration - one line per configuration property (action
name, verb, api name, api gw url)
+ * Parses and initializes values for ApiFilteredRow struct
*/
-func printFilteredListApi(resultApi *whisk.RetApi, api *whisk.ApiOptions) {
+func parseFilteredList(resultApi *whisk.RetApi, api *whisk.ApiOptions,flagType
string) []whisk.ApiFilteredList {
Review comment:
I think the argument label of `flagType` is somewhat generic and should
reflect it's intention (i.e. sortAlg) - with constant values defined as the
supported api sort algorithms.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
