dubeejw commented on a change in pull request #2334: (Review) Added --last
Activation Flag
URL:
https://github.com/apache/incubator-openwhisk/pull/2334#discussion_r125920523
##########
File path: tests/src/test/scala/common/Wsk.scala
##########
@@ -557,14 +557,19 @@ class WskActivation()
* @param activationId the activation id
* @param expectedExitCode (optional) the expected exit code for the
command
* if the code is anything but DONTCARE_EXIT, assert the code is as
expected
+ * @param last retrieves latest acitvation
*/
def get(
- activationId: String,
+ activationId: Option[String] = None,
expectedExitCode: Int = SUCCESS_EXIT,
- fieldFilter: Option[String] = None)(
+ fieldFilter: Option[String] = None,
+ last: Option[Boolean] = None)(
implicit wp: WskProps): RunResult = {
- val params = { fieldFilter map { f => Seq(f) } getOrElse Seq() }
- cli(wp.overrides ++ Seq(noun, "get", "--auth", wp.authKey,
activationId) ++ params, expectedExitCode)
+ val params =
+ { activationId map {a => Seq(a)} getOrElse Seq() } ++
+ { fieldFilter map { f => Seq(f) } getOrElse Seq() } ++
+ { last map {l => Seq("--last")} getOrElse Seq() }
Review comment:
Space needed after `last map {`, and after `Seq("--last")`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
