dubeejw commented on a change in pull request #2334: (Review) Added --last
Activation Flag
URL:
https://github.com/apache/incubator-openwhisk/pull/2334#discussion_r125921950
##########
File path: tools/cli/go-whisk-cli/commands/activation.go
##########
@@ -101,14 +101,22 @@ var activationListCmd = &cobra.Command{
}
var activationGetCmd = &cobra.Command{
- Use: "get ACTIVATION_ID [FIELD_FILTER]",
+ Use: "get (ACTIVATION_ID | --last) [FIELD_FILTER]",
Short: wski18n.T("get activation"),
SilenceUsage: true,
SilenceErrors: true,
PreRunE: setupClientConfig,
RunE: func(cmd *cobra.Command, args []string) error {
var field string
+ var err error
+ if args, err = lastFlag(args); err != nil { // Checks if any errors
occured in lastFlag(args)
+ whisk.Debug(whisk.DbgError, "client.Activation.Get(%#v) failed:
%s\n", args, err)
Review comment:
Debug message should contain `lastFlag` instead of `client.Activation.Get`
since `lastFlag` is the method you are calling, and allows us to trace the code
execution path through debug messages. Same applies to the other instances were
`lastFlag` is called below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
