ningyougang commented on a change in pull request #2427: Support client 
certificate on cli and nginx
URL: 
https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r127109985
 
 

 ##########
 File path: tests/src/test/scala/common/Wsk.scala
 ##########
 @@ -71,6 +71,8 @@ import whisk.utils.retry
 
 case class WskProps(
     authKey: String = 
WhiskProperties.readAuthKey(WhiskProperties.getAuthFileForTesting),
+    cert: String = WhiskProperties.getProperty("openwhisk.home") + 
"/ansible/roles/nginx/files/openwhisk-client-cert.pem",
+    key: String = WhiskProperties.getProperty("openwhisk.home") + 
"/ansible/roles/nginx/files/openwhisk-client-key.pem",
 
 Review comment:
   @rabbah , i don't find the method to return a relative path to whisk home.
   i just find blow method may be can use
   ```
       /**
        * The path to the CLI directory.
        */
       public static String getCLIDir() {
           return whiskHome + "/bin";
       }
   
       /**
        * The path to the Go CLI executable.
        */
       public static String getCLIPath() {
           return getCLIDir() + "/wsk";
       }
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to