ningyougang commented on a change in pull request #2427: Support client
certificate on cli and nginx
URL:
https://github.com/apache/incubator-openwhisk/pull/2427#discussion_r127111207
##########
File path: tests/src/test/scala/common/Wsk.scala
##########
@@ -71,6 +71,8 @@ import whisk.utils.retry
case class WskProps(
authKey: String =
WhiskProperties.readAuthKey(WhiskProperties.getAuthFileForTesting),
+ cert: String = WhiskProperties.getProperty("openwhisk.home") +
"/ansible/roles/nginx/files/openwhisk-client-cert.pem",
+ key: String = WhiskProperties.getProperty("openwhisk.home") +
"/ansible/roles/nginx/files/openwhisk-client-key.pem",
Review comment:
Can you show the method, if doesn't exist, how about add a new method in
`WhiskProperties` like below
```
/**
* The path to the whisk home directory.
*/
public static String getCLIDir() {
return whiskHome;
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
