markusthoemmes commented on a change in pull request #2477: Move load balancer
data into a separate class
URL:
https://github.com/apache/incubator-openwhisk/pull/2477#discussion_r127673972
##########
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
##########
@@ -131,30 +129,26 @@ class LoadBalancerService(
*/
private def processCompletion(response: Either[ActivationId,
WhiskActivation], tid: TransactionId, forced: Boolean): Unit = {
val aid = response.fold(l => l, r => r.activationId)
- activationById.remove(aid) match {
- case Some(entry @ ActivationEntry(_, namespaceId, invokerIndex, _,
p)) =>
- logging.info(this, s"${if (!forced) "received" else "forced"}
active ack for '$aid'")(tid)
- activationByInvoker.getOrElseUpdate(invokerIndex, new
TrieSet[ActivationEntry]).remove(entry)
- activationByNamespaceId.getOrElseUpdate(namespaceId, new
TrieSet[ActivationEntry]).remove(entry)
- if (!forced) {
- p.trySuccess(response)
- } else {
- p.tryFailure(new Throwable("no active ack received"))
- }
+ loadBalancerData.removeActivationById(aid) match {
+ case Some(entry @ ActivationEntry(_, namespaceId, invokerIndex, _, p))
=>
Review comment:
wrong indendation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
