markusthoemmes commented on a change in pull request #2477: Move load balancer
data into a separate class
URL:
https://github.com/apache/incubator-openwhisk/pull/2477#discussion_r128263021
##########
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
##########
@@ -152,43 +140,38 @@ class LoadBalancerService(
* Creates an activation entry and insert into various maps.
*/
private def setupActivation(action: ExecutableWhiskAction, activationId:
ActivationId, namespaceId: UUID, invokerName: String, transid: TransactionId):
ActivationEntry = {
- // either create a new promise or reuse a previous one for this
activation if it exists
+
val timeout = action.limits.timeout.duration + activeAckTimeoutGrace
Review comment:
@vvraskin there is a theoretical possibility here in that `ActivationEntry`
is more than just the ActivationId. In a concurrent case we could add
duplicates.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
