mdeuser commented on a change in pull request #2520: Prints bashauto-completion
install script to STDOUT
URL:
https://github.com/apache/incubator-openwhisk/pull/2520#discussion_r130685580
##########
File path: tools/cli/go-whisk-cli/commands/sdk.go
##########
@@ -74,17 +75,23 @@ var sdkInstallCmd = &cobra.Command{
case "ios":
err = iOSInstall()
case "bashauto":
- err = WskCmd.GenBashCompletionFile(BASH_AUTOCOMPLETE_FILENAME)
- if (err != nil) {
- whisk.Debug(whisk.DbgError, "GenBashCompletionFile('%s`)
error: \n", BASH_AUTOCOMPLETE_FILENAME, err)
- errStr := wski18n.T("Unable to generate '{{.name}}': {{.err}}",
- map[string]interface{}{"name":
BASH_AUTOCOMPLETE_FILENAME, "err": err})
+ whisk.Debug(whisk.DbgInfo, "Running bashauto script\n")
+ if err = WskCmd.GenBashCompletion(os.Stdout); err != nil {
+ whisk.Debug(whisk.DbgError, "GenBashCompletion error: %s\n",
err)
+ errStr := wski18n.T("Unable to generate bashauto-completion
{{.err}}",
Review comment:
trying to maintain consistent wording with docs.... `unable to output...`
(use `output` instead of `generate`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
