mdeuser commented on a change in pull request #2520: Prints bashauto-completion 
install script to STDOUT
URL: 
https://github.com/apache/incubator-openwhisk/pull/2520#discussion_r130686706
 
 

 ##########
 File path: tools/vagrant/Vagrantfile
 ##########
 @@ -155,7 +155,6 @@ $script_end = <<SCRIPT
   chmod +x ${HOME}/bin/wsk
   chown vagrant:vagrant ${HOME}/bin/wsk
   PATH=${PATH}:${HOME}/bin
-  echo 'pushd "$(mktemp -d)" > /dev/null && wsk sdk install bashauto > 
/dev/null && source wsk_cli_bash_completion.sh && popd > /dev/null' >> 
$HOME/.bashrc
 
 Review comment:
   replace this with the good old `eval wsk sdk install bashauto` command
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to