markusthoemmes commented on a change in pull request #2414: SPI approach for pluggable implementations URL: https://github.com/apache/incubator-openwhisk/pull/2414#discussion_r130927003
########## File path: common/scala/src/main/scala/whisk/core/database/CouchDBStoreProvider.scala ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package whisk.core.database + +import akka.actor.ActorSystem +import spray.json.RootJsonFormat +import whisk.common.Logging +import whisk.core.WhiskConfig +import whisk.spi.SpiModule + +/** + * A CouchDB implementation of ArtifactStoreProvider + */ +class CouchDBStoreProvider extends ArtifactStoreProvider { + def makeStore[D <: DocumentSerializer](config: WhiskConfig, name: WhiskConfig => String)( + implicit jsonFormat: RootJsonFormat[D], + actorSystem: ActorSystem, + logging: Logging): ArtifactStore[D] = { + require(config != null && config.isValid, "config is undefined or not valid") + require(config.dbProvider == "Cloudant" || config.dbProvider == "CouchDB", "Unsupported db.provider: " + config.dbProvider) + assume(Set(config.dbProtocol, config.dbHost, config.dbPort, config.dbUsername, config.dbPassword, name(config)).forall(_.nonEmpty), "At least one expected property is missing") + + new CouchDbRestStore[D](config.dbProtocol, config.dbHost, config.dbPort.toInt, config.dbUsername, config.dbPassword, name(config)) + } +} + +class CouchDBStoreProviderModule extends SpiModule[ArtifactStoreProvider] { + def getInstance = new CouchDBStoreProvider +} Review comment: The interface seems weird to me. Why do we need the intermediary object if the class has a constructor without parameters? Can we even implement this solely in a factory object? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
