dubeejw commented on a change in pull request #2424: Allow optional leading
slash in CLI commands
URL:
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131718924
##########
File path: tools/cli/go-whisk-cli/commands/activation.go
##########
@@ -63,11 +63,11 @@ var activationListCmd = &cobra.Command{
if len(args) == 1 {
whisk.Debug(whisk.DbgInfo, "Activation item name filter '%s'
provided\n", args[0])
- if qualifiedName, err = parseQualifiedName(args[0]); err != nil {
- return parseQualifiedNameError(args[0], err)
+ if qualifiedName, err = NewQualifiedName(args[0]); err != nil {
+ return NewQualifiedNameError(args[0], err)
}
- client.Namespace = qualifiedName.namespace
+ client.Namespace = qualifiedName.GetNamespace()
Review comment:
Need to refactor `name: qualifiedName.entityName,` on line 74.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
