dubeejw commented on a change in pull request #2424: Allow optional leading
slash in CLI commands
URL:
https://github.com/apache/incubator-openwhisk/pull/2424#discussion_r131736514
##########
File path: tools/cli/go-whisk-cli/commands/trigger.go
##########
@@ -425,25 +425,27 @@ var triggerListCmd = &cobra.Command{
PreRunE: setupClientConfig,
RunE: func(cmd *cobra.Command, args []string) error {
var err error
- var qualifiedName QualifiedName
+ var qualifiedName = new(QualifiedName)
if whiskErr := checkArgs(args, 0, 1, "Trigger list",
wski18n.T("An optional namespace is the only valid argument."));
whiskErr != nil {
return whiskErr
}
if len(args) == 1 {
- if qualifiedName, err = parseQualifiedName(args[0]); err != nil {
- return parseQualifiedNameError(args[0], err)
+ if qualifiedName, err = NewQualifiedName(args[0]); err != nil {
+ return NewQualifiedNameError(args[0], err)
}
- if len(qualifiedName.entityName) > 0 {
- return entityNameError(qualifiedName.entityName)
+ if len(qualifiedName.GetEntityName()) > 0 {
+ return entityNameError(qualifiedName.GetEntityName())
}
- client.Namespace = qualifiedName.namespace
+ client.Namespace = qualifiedName.GetNamespace()
}
+ //fmt.Println("Package name: ", qualifiedName.GetPackageName())
Review comment:
Delete comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
