markusthoemmes commented on a change in pull request #2584: SPI for Loadbalancer
URL:
https://github.com/apache/incubator-openwhisk/pull/2584#discussion_r131842596
##########
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/LoadBalancerService.scala
##########
@@ -77,16 +82,32 @@ trait LoadBalancer {
*/
def publish(action: ExecutableWhiskAction, msg:
ActivationMessage)(implicit transid: TransactionId):
Future[Future[Either[ActivationId, WhiskActivation]]]
+ /**
+ * Return a message indicating the health of the containers and/or
container pool in general
+ * @return a Future[String] representing the heal response that will be
sent to the client
+ */
+ def getHealthResponse: Future[String]
Review comment:
This should not be a `String` but rather a `JsObject` . It needs to contain
the health of each invoker specifically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
