markusthoemmes commented on a change in pull request #2584: SPI for Loadbalancer
URL:
https://github.com/apache/incubator-openwhisk/pull/2584#discussion_r132405059
##########
File path:
common/scala/src/main/scala/whisk/core/database/CouchDbStoreProvider.scala
##########
@@ -18,16 +18,18 @@
package whisk.core.database
import akka.actor.ActorSystem
+import scala.collection.mutable
import spray.json.RootJsonFormat
import whisk.common.Logging
import whisk.core.WhiskConfig
import whisk.spi.Dependencies
-import whisk.spi.SpiFactory
+import whisk.spi.SingletonSpiFactory
/**
* A CouchDB implementation of ArtifactStoreProvider
*/
class CouchDbStoreProvider extends ArtifactStoreProvider {
+ protected[database] val stores = mutable.Map [String,
CouchDbRestStore[_]]()
Review comment:
Whitespace:
```scala
protected[database] val stores = mutable.Map[String, CouchDbRestStore[_]]()
```
Could this be private?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
