ningyougang commented on issue #2595: Move variable limits to ansible/group_vars/all URL: https://github.com/apache/incubator-openwhisk/pull/2595#issuecomment-321212609 @markusthoemmes ,for `defaultLimits` and `limits`, i just know it is using for `benchmarks test`, i don't know here why remove `defaultLimits`, if remove, below statements will also be removed ``` "DEFAULTLIMITS_ACTIONS_INVOKES_PERMINUTE": "{{ defaultLimits.actions.invokes.perMinute }}" "DEFAULTLIMITS_ACTIONS_INVOKES_CONCURRENT": "{{ defaultLimits.actions.invokes.concurrent }}" "DEFAULTLIMITS_TRIGGERS_FIRES_PERMINUTE": "{{ defaultLimits.triggers.fires.perMinute }}" "DEFAULTLIMITS_ACTIONS_INVOKES_CONCURRENTINSYSTEM": "{{ defaultLimits.actions.invokes.concurrentInSystem }}" "DEFAULTLIMITS_ACTIONS_SEQUENCE_MAXLENGTH": "{{ defaultLimits.actions.sequence.maxLength }}" ``` Has any bad influences? What's the difference between `defaultLimits` and `limits`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
With regards, Apache Git Services
