drcariel commented on a change in pull request #2591: User-Agent CLI/version
header
URL:
https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r133314355
##########
File path: tests/src/test/scala/whisk/core/cli/test/WskWebActionsTests.scala
##########
@@ -250,7 +172,7 @@ trait WskWebActionsTests
response.statusCode shouldBe 200
response.header("Access-Control-Allow-Origin") shouldBe "*"
response.header("Access-Control-Allow-Methods") shouldBe
"OPTIONS, GET, DELETE, POST, PUT, HEAD, PATCH"
- response.header("Access-Control-Allow-Headers") shouldBe
"Authorization, Content-Type"
+ response.header("Access-Control-Allow-Headers") shouldBe
"Authorization, Content-Type, User-Agent"
Review comment:
Maybe I am confused, but I thought this user-agent header was for our own
tracking data, not any thing that is exposed to the user for customization.
Would enforcing this for web actions potentially hinder users from implementing
their own user-agent header? and/or also force them to add a user-agent to all
their web action calls?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
