mdeuser commented on a change in pull request #2591: User-Agent CLI/version
header
URL:
https://github.com/apache/incubator-openwhisk/pull/2591#discussion_r133432706
##########
File path: tests/src/test/scala/whisk/core/cli/test/WskWebActionsTests.scala
##########
@@ -250,7 +172,7 @@ trait WskWebActionsTests
response.statusCode shouldBe 200
response.header("Access-Control-Allow-Origin") shouldBe "*"
response.header("Access-Control-Allow-Methods") shouldBe
"OPTIONS, GET, DELETE, POST, PUT, HEAD, PATCH"
- response.header("Access-Control-Allow-Headers") shouldBe
"Authorization, Content-Type"
+ response.header("Access-Control-Allow-Headers") shouldBe
"Authorization, Content-Type, User-Agent"
Review comment:
@drcariel - requests to the controller can come from the cli, gui, apps
using the rest interface, and web action invocations. each can and will have a
different user agent header, so the controller must be application agnostic wrt
user agent header handling. the controller does not enforce that a user agent
header be part of an incoming request. if the user agent header is included,
then the controller will handle it like any other benign header the controller
does not explicitly act upon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
