rabbah commented on a change in pull request #2632: Use the stale parameter on
listing activations
URL:
https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r133672101
##########
File path: common/scala/src/main/scala/whisk/core/database/ArtifactStore.scala
##########
@@ -84,7 +84,7 @@ trait ArtifactStore[DocumentAbstraction] {
* @param transid the transaction id for logging
* @return a future that completes with List[JsObject] of all documents
from view between start and end key (list may be empty)
*/
- protected[core] def query(table: String, startKey: List[Any], endKey:
List[Any], skip: Int, limit: Int, includeDocs: Boolean, descending: Boolean,
reduce: Boolean)(
+ protected[core] def query(table: String, startKey: List[Any], endKey:
List[Any], skip: Int, limit: Int, includeDocs: Boolean, descending: Boolean,
reduce: Boolean, stale: Option[String])(
implicit transid: TransactionId): Future[List[JsObject]]
Review comment:
Could be Boolean and serialize to ok where it bottoms out into the app call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
