rabbah commented on a change in pull request #2632: Use the stale parameter on
listing activations
URL:
https://github.com/apache/incubator-openwhisk/pull/2632#discussion_r134729025
##########
File path: common/scala/src/main/scala/whisk/core/entity/WhiskStore.scala
##########
@@ -205,12 +208,13 @@ object WhiskEntityQueries {
def listEntitiesInNamespace[A <: WhiskEntity](
db: ArtifactStore[A],
namespace: EntityPath,
- includeDocs: Boolean)(
+ includeDocs: Boolean,
+ stale: StaleParameter = StaleParameter.No)(
implicit transid: TransactionId): Future[Map[String,
List[JsObject]]] = {
implicit val ec = db.executionContext
val startKey = List(namespace.toString)
val endKey = List(namespace.toString, TOP)
- db.query(viewname(ENTITIES), startKey, endKey, 0, 0, includeDocs,
descending = true, reduce = false) map {
+ db.query(viewname(ENTITIES), startKey, endKey, 0, 0, includeDocs,
descending = true, reduce = false, stale = stale) map {
Review comment:
I would have used just stale instead of stale = stale; since the name is
indicative vs just a Boolean.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
