tysonnorris commented on a change in pull request #2659: Containerfactory SPI
URL:
https://github.com/apache/incubator-openwhisk/pull/2659#discussion_r134556951
##########
File path: common/scala/src/main/scala/whisk/core/containerpool/Container.scala
##########
@@ -66,15 +74,3 @@ case class BlackboxStartupError(msg: String) extends
ContainerStartupError(msg)
/** Indicates an error while initializing a container */
case class InitializationError(interval: Interval, response:
ActivationResponse) extends Exception(response.toString)
-
-case class Interval(start: Instant, end: Instant) {
- def duration = Duration.create(end.toEpochMilli() - start.toEpochMilli(),
MILLISECONDS)
-}
-
-object Interval {
- /** An interval starting now with zero duration. */
- def zero = {
- val now = Instant.now
- Interval(now, now)
- }
-}
Review comment:
I'm suggesting that container management can be handled outside of an
invoker, therefore Container related interfaces do not belong there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
