tysonnorris commented on a change in pull request #2659: Containerfactory SPI
URL:
https://github.com/apache/incubator-openwhisk/pull/2659#discussion_r136872739
##########
File path:
core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainer.scala
##########
@@ -120,7 +122,7 @@ object DockerContainer {
* @param id the id of the container
* @param ip the ip of the container
*/
-class DockerContainer(id: ContainerId, ip: ContainerIp)(
+class DockerContainer(val id: ContainerId, val ip: ContainerIp)(
Review comment:
id/ip are needed by the HTTP API during initialize() and run() - latest
changes have these as protected val, but also has the HTTP API methods
initialize() and run() moved into a separate class so they can be shared - see
ContainerApi.scala
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
