rabbah commented on a change in pull request #2650: Apply standard scala
formatting.
URL:
https://github.com/apache/incubator-openwhisk/pull/2650#discussion_r136238806
##########
File path: common/scala/src/main/scala/whisk/core/connector/Message.scala
##########
@@ -31,89 +31,89 @@ import whisk.core.entity.WhiskActivation
/** Basic trait for messages that are sent on a message bus connector. */
trait Message {
- /**
- * A transaction id to attach to the message.
- */
- val transid = TransactionId.unknown
-
- /**
- * Serializes message to string. Must be idempotent.
- */
- def serialize: String
-
- /**
- * String representation of the message. Delegates to serialize.
- */
- override def toString = serialize
+
+ /**
+ * A transaction id to attach to the message.
+ */
+ val transid = TransactionId.unknown
+
+ /**
+ * Serializes message to string. Must be idempotent.
+ */
+ def serialize: String
+
+ /**
+ * String representation of the message. Delegates to serialize.
+ */
+ override def toString = serialize
}
-case class ActivationMessage(
- override val transid: TransactionId,
- action: FullyQualifiedEntityName,
- revision: DocRevision,
- user: Identity,
- activationId: ActivationId,
- activationNamespace: EntityPath,
- rootControllerIndex: InstanceId,
- content: Option[JsObject],
- cause: Option[ActivationId] = None)
+case class ActivationMessage(override val transid: TransactionId,
+ action: FullyQualifiedEntityName,
+ revision: DocRevision,
+ user: Identity,
+ activationId: ActivationId,
+ activationNamespace: EntityPath,
+ rootControllerIndex: InstanceId,
+ content: Option[JsObject],
+ cause: Option[ActivationId] = None)
Review comment:
visually i like the old style better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
