rabbah commented on a change in pull request #2650: Apply standard scala
formatting.
URL:
https://github.com/apache/incubator-openwhisk/pull/2650#discussion_r136238505
##########
File path: common/scala/src/main/scala/whisk/common/Scheduler.scala
##########
@@ -33,99 +33,93 @@ import akka.actor.Props
* even for asynchronous tasks.
*/
object Scheduler {
- case object WorkOnceNow
- private case object ScheduledWork
+ case object WorkOnceNow
+ private case object ScheduledWork
- /**
- * Sets up an Actor to send itself a message to mimic schedulers behavior
in a more controllable way.
- *
- * @param interval the time to wait between two runs
- * @param alwaysWait always wait for the given amount of time or calculate
elapsed time to wait
- * @param closure the closure to be executed
- */
- private class Worker(
- initialDelay: FiniteDuration,
- interval: FiniteDuration,
- alwaysWait: Boolean,
- name: String,
- closure: () => Future[Any])(
- implicit logging: Logging,
- transid: TransactionId) extends Actor {
- implicit val ec = context.dispatcher
+ /**
+ * Sets up an Actor to send itself a message to mimic schedulers behavior in
a more controllable way.
+ *
+ * @param interval the time to wait between two runs
+ * @param alwaysWait always wait for the given amount of time or calculate
elapsed time to wait
+ * @param closure the closure to be executed
+ */
+ private class Worker(initialDelay: FiniteDuration,
+ interval: FiniteDuration,
+ alwaysWait: Boolean,
+ name: String,
+ closure: () => Future[Any])(implicit logging: Logging,
transid: TransactionId)
Review comment:
can we make implicit break?
if this is a longer line, what'll look like?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
