markusthoemmes commented on a change in pull request #2584: SPI for Loadbalancer URL: https://github.com/apache/incubator-openwhisk/pull/2584#discussion_r137178270
########## File path: tests/src/test/scala/whisk/core/database/test/CouchDBStoreProviderTests.scala ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package whisk.core.database.test + +import common.StreamLogging +import common.WskActorSystem +import org.junit.runner.RunWith +import org.scalatest.FlatSpec +import org.scalatest.Matchers +import org.scalatest.junit.JUnitRunner +import whisk.core.WhiskConfig +import whisk.core.WhiskConfig._ +import whisk.core.database.ArtifactStoreProvider +import whisk.core.entity.WhiskActivation +import whisk.spi.SpiLoader + +@RunWith(classOf[JUnitRunner]) +class CouchDBStoreProviderTests extends FlatSpec + with Matchers + with WskActorSystem + with StreamLogging { + val config = new WhiskConfig(Map( + dbProvider -> "CouchDB", + dbProtocol -> "http", + dbUsername -> "fake", + dbPassword -> "fake", + dbHost -> "fake", + dbPort -> "1234", + dbActivations -> "activations_fake")) + + + val artifactStoreProvider = SpiLoader.get[ArtifactStoreProvider]() + val store1FirstLoad = artifactStoreProvider.makeStore[WhiskActivation](config, _.dbActivations) + val store1SecondLoad = artifactStoreProvider.makeStore[WhiskActivation](config, _.dbActivations) + + behavior of "CouchDBStoreProvider" + override def afterAll() { + println("Shutting down store connections") + store1FirstLoad.shutdown() + //do not need to shutdown the second loaded store, but we'll do it anyways since clients may do that also + store1SecondLoad.shutdown() + super.afterAll() + } + it should "load the same store from config for a specific artifact type" in { + store1FirstLoad shouldBe store1SecondLoad + } Review comment: Given the more general implementation you had in another PR (as discussed in Slack), should this be tested in a more general way? Also: Should we add a test which asserts that two stores with different names are different instances? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
