tysonnorris commented on issue #2648: Overhaul logging URL: https://github.com/apache/incubator-openwhisk/pull/2648#issuecomment-327602675 I've been confused by the need to use the whisk.common.Logging class at all - is there any reason not to use slf4j classes directly, like many projects do? e.g. instead of every class having to pass Logging around, use something like ```val logger: Logger = LoggerFactory.getLogger(this.getClass)``` (or one per package, instead of one per class, etc). This way you can a) get rid of Logging code in the codebase and b) enable logger customization for specific packages/classes using standard conventions (via logback config) Similarly, it may be possible to use MDC for TransactionId (instead of passing it everywhere), and slf4j markers (or some custom layout?) instead of (or in conjunction with) existing LoggingMarkers. Its unclear whether these specialized logging utilities were added for specific reasons, but if not, it may be nice to use readily available tools for these jobs. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
With regards, Apache Git Services
