tysonnorris commented on a change in pull request #2689: first stage of support
for dynamic invoker id assignment
URL:
https://github.com/apache/incubator-openwhisk/pull/2689#discussion_r137651170
##########
File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
##########
@@ -87,6 +89,38 @@ object Invoker {
val msgProvider = SpiLoader.get[MessagingProvider]
val producer = msgProvider.getProducer(config, ec)
+
+ val invokerUUID = sys.env.getOrElse("INVOKER_ASSIGNED_UUID",
UUID().toString)
+ val proposedInvokerId = if (args.length == 1) { args(0).toInt } else { -1 }
Review comment:
I think either `invokerUUID` or `proposedInvokerId` must always be specified
- if you allow UUID() on each restart, for example, the assigned invokerId will
be incremented each time, abandoning the previous id's assigned topic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services