tysonnorris commented on a change in pull request #2689: first stage of support
for dynamic invoker id assignment
URL:
https://github.com/apache/incubator-openwhisk/pull/2689#discussion_r141497396
##########
File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
##########
@@ -85,6 +86,41 @@ object Invoker {
abort()
}
+ val proposedInvokerId: Option[Int] = args.headOption.map(_.toInt)
+ val assignedInvokerId = proposedInvokerId
+ .map { id =>
+ logger.info(this, s"invokerReg: using proposedInvokerId ${id}")
+ id
+ }
+ .getOrElse {
+ val invokerName = config.invokerName
Review comment:
My question is about whether `config.invokerName` has to be statically
assigned as an environment variable `INVOKER_NAME=MyInvokerName`, or if it can
be derived from either a system property or other environment variable, e.g.
`INVOKER_NAME=${SOME_VALUE}` (where `SOME_VALUE` is another variable). Or, if
it was possible to pass it as an arg, that would also be a way to use
`$SOME_VALUE`, but currently it isn't.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
