rabbah commented on a change in pull request #2531: Share bookkeeping data
across controllers
URL:
https://github.com/apache/incubator-openwhisk/pull/2531#discussion_r138445206
##########
File path:
core/controller/src/main/scala/whisk/core/controller/Controller.scala
##########
@@ -169,11 +168,13 @@ object Controller {
"runtimes" -> runtimes.toJson)
def main(args: Array[String]): Unit = {
- implicit val actorSystem = ActorSystem("controller-actor-system")
- implicit val logger = new
AkkaLogging(akka.event.Logging.getLogger(actorSystem, this))
// extract configuration data from the environment
val config = new WhiskConfig(requiredProperties)
+
+ implicit val actorSystem = ActorSystem("controller-actor-system",
SharedDataService.addAkkaSeedNodesToConf(config))
+ implicit val logger = new
AkkaLogging(akka.event.Logging.getLogger(actorSystem, this))
Review comment:
Was the logger removed because of a phase ordering here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
