rabbah commented on a change in pull request #2531: Share bookkeeping data
across controllers
URL:
https://github.com/apache/incubator-openwhisk/pull/2531#discussion_r138444423
##########
File path: common/scala/src/main/scala/whisk/common/Config.scala
##########
@@ -146,11 +145,9 @@ object Config {
* @param required a key-value map where the keys are required properties
* @param properties a set of properties to check
*/
- def validateProperties(required: Map[String, String], properties:
Map[String, String])(
- implicit logging: Logging): Boolean = {
+ def validateProperties(required: Map[String, String], properties:
Map[String, String]): Boolean = {
required.keys.forall { key =>
val value = properties(key)
- if (value == null) logging.error(this, s"required property $key still
not set")
Review comment:
why removing the loggers?
this is particularly useful when a deployment fails and you dont know why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
