rabbah commented on a change in pull request #2686: Docker for mac take 2
URL:
https://github.com/apache/incubator-openwhisk/pull/2686#discussion_r138742442
##########
File path: ansible/logs.yml
##########
@@ -27,11 +27,19 @@
- hosts: all:!ansible
serial: 1
tasks:
+ - name: set host flag
+ set_fact:
+ docker_host_flag: "--host tcp://{{ ansible_host }}:{{ docker.port }}"
+ when: (whisk_version_name == "mac" or ansible_os_family == "Debian")
+ - name: do not set host flag when Docker mac
+ set_fact:
+ docker_host_flag: ""
+ when: (whisk_version_name != "mac" and ansible_os_family != "Debian")
- name: get all docker containers
- local_action: shell docker --host tcp://{{ ansible_host }}:{{ docker.port
}} ps -a --format="{% raw %}{{.Names}}{% endraw %}"
+ local_action: shell docker {{ docker_host_flag }} ps -a --format="{% raw
%}{{.Names}}{% endraw %}"
Review comment:
extra space after `docker` here and line 42.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
