rabbah commented on a change in pull request #2686: Docker for mac take 2
URL:
https://github.com/apache/incubator-openwhisk/pull/2686#discussion_r138755173
##########
File path: ansible/roles/invoker/tasks/deploy.yml
##########
@@ -40,23 +56,43 @@
- name: define options when deploying invoker on Ubuntu
set_fact:
linuxOptions: "-v
/usr/lib/x86_64-linux-gnu/libapparmor.so.1:/usr/lib/x86_64-linux-gnu/libapparmor.so.1"
- when: whisk_version_name != "mac"
+ when: ansible_distribution == "Ubuntu"
- name: get running invoker information
- uri:
- url: "http://{{ ansible_host }}:{{ docker.port
}}/containers/json?filters={{ '{\"name\":[ \"invoker\" ],\"ancestor\":[
\"invoker\" ]}' | urlencode }}"
- return_content: yes
- register: invokerInfo
+ uri: url="http://{{ inventory_hostname }}:{{ docker.port
}}/containers/json?filters={{ '{"name":[ "invoker" ]}' | urlencode }}"
return_content=yes
Review comment:
losing the `ancestor` filter is that deliberate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
