ddragosd commented on a change in pull request #2531: Share bookkeeping data
across controllers
URL:
https://github.com/apache/incubator-openwhisk/pull/2531#discussion_r139560912
##########
File path:
core/controller/src/main/scala/whisk/core/loadBalancer/SharedDataService.scala
##########
@@ -75,6 +53,7 @@ class SharedDataService(storageName: String) extends Actor
with ActorLogging {
* Subscribe this node for the changes in the Map, initialize the Map
*/
override def preStart(): Unit = {
+ node.joinSeedNodes(seedNodes)
Review comment:
I'm a little unsure about `joinSeedNodes` to be used from within an actor.
IIUC this command has a cluster wide impact, it's not only related to this
actor, in which case, wouldn't it make sense to surface it in a more global
place ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
